Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: LayoutTests/http/tests/serviceworker/client-id.html

Issue 1209493002: Service Worker: Surface Client.id attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add a reference to RFC4122. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/client-id.html
diff --git a/LayoutTests/http/tests/serviceworker/client-id.html b/LayoutTests/http/tests/serviceworker/client-id.html
new file mode 100644
index 0000000000000000000000000000000000000000..93432e723c23c7a7bce94dc71a7c8311fc4cc96d
--- /dev/null
+++ b/LayoutTests/http/tests/serviceworker/client-id.html
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<title>Service Worker: Client.id</title>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="resources/test-helpers.js"></script>
+<script>
+var scope = 'resources/blank.html?client-id';
+var t = async_test('Test Client.id');
falken 2015/06/25 04:09:56 our style guide does async_test(function(t) { //te
jungkees 2015/06/25 07:48:36 Right. Corrected it accordingly.
+var frame1, frame2;
+t.step(function() {
+ service_worker_unregister_and_register(
+ t, 'resources/client-id-worker.js', scope)
+ .then(function(registration) {
+ return wait_for_state(t, registration.installing, 'activated');
+ })
+ .then(function() { return with_iframe(scope + '#1'); })
+ .then(function(f) {
+ frame1 = f;
+ f.focus();
falken 2015/06/25 04:09:56 why do we need to focus()?
jungkees 2015/06/25 07:48:36 This is to be sure Clients.matchAll() calls iterat
+ return with_iframe(scope + '#2');
+ })
+ .then(function(f) {
+ frame2 = f;
+ var channel = new MessageChannel();
+ channel.port1.onmessage = t.step_func(onMessage);
+ f.contentWindow.navigator.serviceWorker.controller.postMessage(
+ {port:channel.port2}, [channel.port2]);
+ })
+ .catch(unreached_rejection(t));
+ });
+
+// A regex object for UUID(http://tools.ietf.org/html/rfc4122) validation.
+var pattern = new RegExp (['^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0',
falken 2015/06/25 04:09:56 nit: no space before the (
+ '-9a-f]{3}-[0-9a-f]{12}$'].join(''), 'i');
+function validateUUID(id) {
falken 2015/06/25 04:09:56 nit: validate_uuid
+ return id.match(pattern) ? true : false;
+}
+
+function onMessage(e) {
falken 2015/06/25 04:09:56 nit: on_message
+ // The result of two sequential clients.matchAll() calls in the SW.
+ // 1st matchAll() results in e.data[0], e.data[1].
+ // 2nd matchAll() results in e.data[2], e.data[3].
+ assert_equals(e.data.length, 4);
+ // All should be valid UUIDs.
+ assert_true(validateUUID(e.data[0]));
+ assert_true(validateUUID(e.data[1]));
+ assert_true(validateUUID(e.data[2]));
+ assert_true(validateUUID(e.data[3]));
+ // Different clients should have different ids.
+ assert_not_equals(e.data[0], e.data[1]);
+ assert_not_equals(e.data[2], e.data[3]);
+ // Same clients should have an identical id.
+ assert_equals(e.data[0], e.data[2]);
+ assert_equals(e.data[1], e.data[3]);
+ frame1.remove();
+ frame2.remove();
+ service_worker_unregister_and_done(t, scope);
+}
+</script>

Powered by Google App Engine
This is Rietveld 408576698