Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: Source/modules/presentation/PresentationSessionClientCallbacks.cpp

Issue 1209473003: Marks session as connected upon StartSession success (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/presentation/PresentationSessionClientCallbacks.cpp
diff --git a/Source/modules/presentation/PresentationSessionClientCallbacks.cpp b/Source/modules/presentation/PresentationSessionClientCallbacks.cpp
index 10033511af7fd644826875b4e18c519f6635feb6..18e55120e03ba6829bb90204af3c0787316c274b 100644
--- a/Source/modules/presentation/PresentationSessionClientCallbacks.cpp
+++ b/Source/modules/presentation/PresentationSessionClientCallbacks.cpp
@@ -39,7 +39,9 @@ void PresentationSessionClientCallbacks::onSuccess(WebPresentationSessionClient*
return;
}
- m_resolver->resolve(PresentationSession::take(client, m_presentation));
+ PresentationSession* session = PresentationSession::take(client, m_presentation);
+ session->didChangeState(WebPresentationSessionState::Connected);
whywhat 2015/06/25 17:33:45 Seems wasteful to dispatch an event to just create
haibinlu 2015/06/25 18:45:36 Make sense. Pass in the initial state.
+ m_resolver->resolve(session);
}
void PresentationSessionClientCallbacks::onError(WebPresentationError* error)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698