Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1209423008: Make the TaskDescription background color match the ToolBar on Android (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the TaskDescription background color match the ToolBar on Android This isn't quite perfect since we seem to do a second layout as the activity switcher is brought up which is shifting down our toolbar and making it bleed slightly below the Activity Switcher's Task description bar. But at least we're the right color now. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c4603759013c0896fe8b0e5345f0017a76fb8a77

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated per review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M sky/sdk/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/stocks/lib/main.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M sky/sdk/lib/mojo/activity.dart View 1 3 chunks +19 lines, -0 lines 0 comments Download
A sky/sdk/lib/widgets/task_description.dart View 1 1 chunk +19 lines, -0 lines 2 comments Download
M sky/services/intents/intents.mojom View 1 2 chunks +6 lines, -0 lines 0 comments Download
M sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
LGTM https://codereview.chromium.org/1209423008/diff/1/sky/sdk/lib/widgets/task_description.dart File sky/sdk/lib/widgets/task_description.dart (right): https://codereview.chromium.org/1209423008/diff/1/sky/sdk/lib/widgets/task_description.dart#newcode23 sky/sdk/lib/widgets/task_description.dart:23: void updateTaskDescription(String label, Color color) { Can we ...
5 years, 5 months ago (2015-07-07 19:57:46 UTC) #2
eseidel
Committed patchset #2 (id:20001) manually as c4603759013c0896fe8b0e5345f0017a76fb8a77 (presubmit successful).
5 years, 5 months ago (2015-07-07 20:56:10 UTC) #3
Hixie
5 years, 5 months ago (2015-07-07 23:13:03 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1209423008/diff/20001/sky/sdk/lib/widgets/tas...
File sky/sdk/lib/widgets/task_description.dart (right):

https://codereview.chromium.org/1209423008/diff/20001/sky/sdk/lib/widgets/tas...
sky/sdk/lib/widgets/task_description.dart:10: Widget child;
these should be final, and after the constructor

https://codereview.chromium.org/1209423008/diff/20001/sky/sdk/lib/widgets/tas...
sky/sdk/lib/widgets/task_description.dart:13: TaskDescription({this.label,
this.child});
put spaces inside the {}s around the arguments

Powered by Google App Engine
This is Rietveld 408576698