Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1209423002: Add support for build_limited subprojects in presubmit builder (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 5 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Renamed build_limited config to build_limited_scripts_slave R=phajdan.jr@chromium.org BUG=504360 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295898

Patch Set 1 #

Patch Set 2 : Added a comment #

Patch Set 3 : Rewrote as a single build_limited_scripts_slave repo #

Patch Set 4 : Changed things back since we need to checkout build_limited alongside build #

Patch Set 5 : Fix #

Patch Set 6 : Fix #

Patch Set 7 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -122 lines) Patch
M scripts/slave/recipe_modules/gclient/config.py View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/rietveld/api.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.py View 1 2 3 4 5 2 chunks +13 lines, -2 lines 0 comments Download
D scripts/slave/recipes/run_presubmit.expected/build_limited.json View 1 chunk +0 lines, -113 lines 0 comments Download
A + scripts/slave/recipes/run_presubmit.expected/build_limited_scripts_slave.json View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-26 13:49:32 UTC) #1
Paweł Hajdan Jr.
LGTM
5 years, 6 months ago (2015-06-26 14:31:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209423002/100001
5 years, 5 months ago (2015-07-01 13:54:49 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 13:58:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295898

Powered by Google App Engine
This is Rietveld 408576698