Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1209413008: [turbofan] Move MulHigh asr onto add on ARM64 (Closed)

Created:
5 years, 5 months ago by martyn.capewell
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move MulHigh asr onto add on ARM64 Move the arithmetic shift from Int32MulHigh to a following Int32Add on ARM64. This graph is commonly generated on reduction of signed integer division. Committed: https://crrev.com/7374e6dc8955c41e7046573837ddedd78033c3a8 Cr-Commit-Position: refs/heads/master@{#29380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
martyn.capewell
5 years, 5 months ago (2015-06-30 12:48:29 UTC) #2
Benedikt Meurer
LGTM.
5 years, 5 months ago (2015-06-30 12:59:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209413008/1
5 years, 5 months ago (2015-06-30 13:06:50 UTC) #5
commit-bot: I haz the power
The author martyn.capewell@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-06-30 13:06:51 UTC) #6
commit-bot: I haz the power
The author martyn.capewell@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-06-30 13:30:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 13:40:05 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 13:40:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7374e6dc8955c41e7046573837ddedd78033c3a8
Cr-Commit-Position: refs/heads/master@{#29380}

Powered by Google App Engine
This is Rietveld 408576698