Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: BUILD.gn

Issue 1209413007: Suppress warnings for assignment inside conditionals. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: GN too Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | icu.gyp » ('j') | icu.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 "-Wno-deprecated-declarations", 70 "-Wno-deprecated-declarations",
71 "-Wno-logical-op-parentheses", 71 "-Wno-logical-op-parentheses",
72 "-Wno-tautological-compare", 72 "-Wno-tautological-compare",
73 "-Wno-switch", 73 "-Wno-switch",
74 ] 74 ]
75 if (is_win) { 75 if (is_win) {
76 cflags += [ 76 cflags += [
77 # See http://bugs.icu-project.org/trac/ticket/11122 77 # See http://bugs.icu-project.org/trac/ticket/11122
78 "-Wno-inline-new-delete", 78 "-Wno-inline-new-delete",
79 "-Wno-implicit-exception-spec-mismatch", 79 "-Wno-implicit-exception-spec-mismatch",
80 "-Wno-parentheses",
Nico 2015/06/30 04:45:56 I'd probably put this in the general is_clang bloc
80 ] 81 ]
81 } 82 }
82 } 83 }
83 } 84 }
84 85
85 component("icui18n") { 86 component("icui18n") {
86 sources = [ 87 sources = [
87 "source/i18n/alphaindex.cpp", 88 "source/i18n/alphaindex.cpp",
88 "source/i18n/anytrans.cpp", 89 "source/i18n/anytrans.cpp",
89 "source/i18n/astro.cpp", 90 "source/i18n/astro.cpp",
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 sources = [ 563 sources = [
563 "android/icudtl_dat.S", 564 "android/icudtl_dat.S",
564 ] 565 ]
565 } else { 566 } else {
566 assert(false, "No icu data for this platform") 567 assert(false, "No icu data for this platform")
567 } 568 }
568 defines = [ "U_HIDE_DATA_SYMBOL" ] 569 defines = [ "U_HIDE_DATA_SYMBOL" ]
569 } 570 }
570 } 571 }
571 } 572 }
OLDNEW
« no previous file with comments | « no previous file | icu.gyp » ('j') | icu.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698