Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 12094088: Don't ignore failures in build-cocos2dx.sh. (Closed)

Created:
7 years, 10 months ago by Sam Clegg
Modified:
7 years, 10 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Don't ignore failures in build-cocos2dx.sh. Also have make clean clean the naclports and cocos stamps. R=binji BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1482

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M nacltoons/Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M nacltoons/build/build-cocos2dx.sh View 1 chunk +2 lines, -1 line 0 comments Download
M nacltoons/build/build-naclports.sh View 1 chunk +2 lines, -1 line 0 comments Download
M nacltoons/game.mk View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Clegg
7 years, 10 months ago (2013-01-31 21:08:52 UTC) #1
binji
7 years, 10 months ago (2013-01-31 23:52:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698