Chromium Code Reviews| Index: chrome/browser/ui/search/search.h |
| diff --git a/chrome/browser/ui/search/search.h b/chrome/browser/ui/search/search.h |
| index d7364b74e38501a170cda9738853e06223504ff7..562477e26af6d732b96c36dbdf72a84ec24a6115 100644 |
| --- a/chrome/browser/ui/search/search.h |
| +++ b/chrome/browser/ui/search/search.h |
| @@ -17,6 +17,16 @@ class Profile; |
| namespace chrome { |
| namespace search { |
| +enum InstantExtendedDefault { |
| + INSTANT_FORCE_ON, // Force the setting on if no other setting exists. |
| + INSTANT_USE_EXISTING, // Use same the value of the old instant.enabled pref. |
| + INSTANT_FORCE_OFF, // Force the setting off if no other setting exists. |
| +}; |
| + |
| +// Returns an enum value indicating which mode to set the new |
| +// instant_extended.enabled pref to by default. |
| +InstantExtendedDefault GetInstantExtendedDefaultSetting(); |
| + |
| // Returns whether the Instant extended API is enabled for the given |profile|. |
| // |profile| may not be NULL. |
| bool IsInstantExtendedAPIEnabled(Profile* profile); |
| @@ -45,9 +55,13 @@ bool IsForcedInstantURL(const GURL& url); |
| typedef std::vector<std::pair<std::string, std::string> > FieldTrialFlags; |
| // Given a field trial group name, parses out the group number and configuration |
| -// flags. |
| +// flags. On success, |flags| will be filled with the field trial flags. |flags| |
| +// must not be NULL. If not NULL, |group_number| will receive the experiment |
| +// group number. |
| +// Returns true if field trial info was successfully parsed out of |group_name|, |
| +// false otherwise. |
|
MAD
2013/01/31 20:14:53
nit: false otherwise is not needed and sometimes f
robertshield
2013/01/31 20:24:28
People shouldn't frown, makes for wrinkles. Remove
|
| // Exposed for testing only. |
| -void GetFieldTrialInfo(const std::string& group_name, |
| +bool GetFieldTrialInfo(const std::string& group_name, |
| FieldTrialFlags* flags, |
| uint64* group_number); |