xcode_settings entries with list values override entries with the same key

pylib/gyp/xcodeproj_file.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Xcode project file generator.
 
 This module is both an Xcode project file generator and a documentation of the
 Xcode project file format.  Knowledge of the project file format was gained
 based on extensive experience with Xcode, and by making changes to projects in
 Xcode.app and observing the resultant changes in the associated project files.
@@ skipping 1538 matching lines @@
     'name':                       [0, str,  0, 1],
   })
 
   def HasBuildSetting(self, key):
     return key in self._properties['buildSettings']
 
   def GetBuildSetting(self, key):
     return self._properties['buildSettings'][key]
 
   def SetBuildSetting(self, key, value):
-    # TODO(mark): If a list, copy?
-    self._properties['buildSettings'][key] = value
+    if hasattr(value, '__iter__'):
+      if not key in self._properties['buildSettings']:
+        self._properties['buildSettings'][key] = []
+      self._properties['buildSettings'][key].extend(value)

[Sam Clegg, 2013/01/30 16:08:59]

nit: I think you can write these three lines as one using
the .setdefault() method on the dict.

Actually there is an existing method below called
AppendBuildSettings() that already does this (and should
probably use setdefault() itself).

+    else:
+      self._properties['buildSettings'][key] = value
 
   def AppendBuildSetting(self, key, value):
     if not key in self._properties['buildSettings']:
       self._properties['buildSettings'][key] = []
     self._properties['buildSettings'][key].append(value)
 
   def DelBuildSetting(self, key):
     if key in self._properties['buildSettings']:
       del self._properties['buildSettings'][key]
 
@@ skipping 1289 matching lines @@
       self._XCPrint(file, 0, '/* Begin ' + class_name + ' section */\n')
       for object in sorted(objects_by_class[class_name],
                            cmp=lambda x, y: cmp(x.id, y.id)):
         object.Print(file)
       self._XCPrint(file, 0, '/* End ' + class_name + ' section */\n')
 
     if self._should_print_single_line:
       self._XCPrint(file, 0, '}; ')
     else:
       self._XCPrint(file, 1, '};\n')