Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 12094057: Fixes Windows build bots. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)
Modified:
7 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fixes Windows build bots. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13553

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/mark-compact.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 10 months ago (2013-01-30 12:37:08 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/12094057/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/12094057/diff/1/src/mark-compact.cc#newcode3600 src/mark-compact.cc:3600: size = static_cast<int>(free_end - p->area_start()); This won't resolve the ...
7 years, 10 months ago (2013-01-30 12:40:44 UTC) #2
Hannes Payer (out of office)
https://chromiumcodereview.appspot.com/12094057/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/12094057/diff/1/src/mark-compact.cc#newcode3600 src/mark-compact.cc:3600: size = static_cast<int>(free_end - p->area_start()); uuups, fixed. On 2013/01/30 ...
7 years, 10 months ago (2013-01-30 12:45:31 UTC) #3
Michael Starzinger
LGTM (but one last comment). https://chromiumcodereview.appspot.com/12094057/diff/2002/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/12094057/diff/2002/src/mark-compact.cc#newcode3600 src/mark-compact.cc:3600: size = static_cast<size_t>(free_end - ...
7 years, 10 months ago (2013-01-30 12:45:58 UTC) #4
Hannes Payer (out of office)
7 years, 10 months ago (2013-01-30 12:47:23 UTC) #5
https://chromiumcodereview.appspot.com/12094057/diff/2002/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/12094057/diff/2002/src/mark-compact.cc...
src/mark-compact.cc:3600: size = static_cast<size_t>(free_end -
p->area_start());
On 2013/01/30 12:45:58, Michael Starzinger wrote:
> Drop this cast, it's unnecessary and might even cause other warnings.

Done.

Powered by Google App Engine
This is Rietveld 408576698