components/password_manager/content/renderer/credential_manager_client.cc - Issue 1209363003: Rename avatar to icon in the credential manager in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_messages.h ('k') | components/password_manager/core/common/credential_manager_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index 66754a7bcc82d35f70743f5f57041d42aa501786..53bf2531348f895b4f171d4e2700763e338bea30 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -85,11 +85,11 @@ void CredentialManagerClient::OnSendCredential(int request_id,

switch (info.type) {

case CredentialType::CREDENTIAL_TYPE_FEDERATED:

credential.reset(new blink::WebFederatedCredential(

- info.id, info.federation, info.name, info.avatar));

+ info.id, info.federation, info.name, info.icon));

break;

case CredentialType::CREDENTIAL_TYPE_PASSWORD:

credential.reset(new blink::WebPasswordCredential(

- info.id, info.password, info.name, info.avatar));

+ info.id, info.password, info.name, info.icon));

break;

case CredentialType::CREDENTIAL_TYPE_EMPTY:

// Intentionally empty; we'll send nullptr to the onSuccess call below.