Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 120933003: Remove socket.h include from debug.h (Closed)

Created:
6 years, 12 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Remove socket.h include from debug.h Looks like there is no Socket usage in debug.h, so we don't need to include it there. TEST=in static build, ninja -C out/Debug/ d8 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18459

Patch Set 1 #

Patch Set 2 : fix for d8-debug.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/d8-debug.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 12 months ago (2013-12-24 17:28:21 UTC) #1
Benedikt Meurer
Your patch breaks the build.
6 years, 11 months ago (2014-01-02 06:54:00 UTC) #2
Benedikt Meurer
NOT LGTM
6 years, 11 months ago (2014-01-02 06:54:20 UTC) #3
tfarina
On 2014/01/02 06:54:00, Benedikt Meurer wrote: > Your patch breaks the build. Could you paste ...
6 years, 11 months ago (2014-01-02 20:35:33 UTC) #4
Benedikt Meurer
On 2014/01/02 20:35:33, tfarina wrote: > On 2014/01/02 06:54:00, Benedikt Meurer wrote: > > Your ...
6 years, 11 months ago (2014-01-03 05:13:01 UTC) #5
Benedikt Meurer
../src/d8-debug.cc: In member function ‘void v8::RemoteDebugger::Run()’: ../src/d8-debug.cc:178:18: error: invalid use of incomplete type ‘struct v8::internal::Socket’ ...
6 years, 11 months ago (2014-01-03 05:14:46 UTC) #6
tfarina
Fixed! PTAL Benedikt. The issue was that I had component:shared_library in my .gyp/include.gypi, so I ...
6 years, 11 months ago (2014-01-03 11:47:49 UTC) #7
tfarina
On 2014/01/03 11:47:49, tfarina wrote: > $ ninja -C out/Debug/ v8 $ ninja -C out/Debug/ ...
6 years, 11 months ago (2014-01-03 11:48:31 UTC) #8
Benedikt Meurer
LGTM, I'll land it.
6 years, 11 months ago (2014-01-07 08:27:35 UTC) #9
Benedikt Meurer
6 years, 11 months ago (2014-01-07 08:28:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r18459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698