Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/frames.cc

Issue 12093089: Support pass-through of stub caller arguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: ARM port Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 98b3d65f955ed9eac36b52fc1f4dc365447bbfa7..0e52e4afaba8777ad31a49f795e3663519728989 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -1304,9 +1304,14 @@ void InternalFrame::Iterate(ObjectVisitor* v) const {
void StubFailureTrampolineFrame::Iterate(ObjectVisitor* v) const {
- const int offset = StandardFrameConstants::kContextOffset;
Object** base = &Memory::Object_at(sp());
- Object** limit = &Memory::Object_at(fp() + offset) + 1;
+ // sizeof(Arguments) - sizeof(Arguments*) is 3 * kPointerSize), but the
+ // presubmit script complains about using sizeof() on a type.
+ Object** limit = &Memory::Object_at(
+ fp() + StandardFrameConstants::kMarkerOffset - 3 * kPointerSize);
mvstanton 2013/02/04 08:54:26 A StubFailureTrampolineFrameConstant would be a ni
danno 2013/02/04 10:22:24 Done.
+ v->VisitPointers(base, limit);
+ limit = &Memory::Object_at(fp());
+ base = &Memory::Object_at(fp() + StandardFrameConstants::kMarkerOffset);
v->VisitPointers(base, limit);
IteratePc(v, pc_address(), LookupCode());
}
« no previous file with comments | « src/deoptimizer.cc ('k') | src/hydrogen-instructions.h » ('j') | src/ia32/code-stubs-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698