Support pass-through of stub caller arguments

Support pass-through of stub caller arguments

Committed: http://code.google.com/p/v8/source/detail?r=13593

[danno, 2013-02-04 08:16:10]

Please take a look

[mvstanton, 2013-02-04 08:54:26]

LGTM. 2 comments on some of the offset math for StubFailureTrampolineFrames.

https://codereview.chromium.org/12093089/diff/15001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/12093089/diff/15001/src/frames.cc#newcode1311
src/frames.cc:1311: fp() + StandardFrameConstants::kMarkerOffset - 3 *
kPointerSize);
A StubFailureTrampolineFrameConstant would be a nice aid for this expression.

https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32....
src/ia32/code-stubs-ia32.cc:7639: 2 * kPointerSize));
Would it make sense to having something like a
StubFailureTrampolineConstants::kArgumentCountOffset for this expression?

[danno, 2013-02-04 10:22:24]

Please take another look, some minor surgery was needed.

https://codereview.chromium.org/12093089/diff/15001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/12093089/diff/15001/src/frames.cc#newcode1311
src/frames.cc:1311: fp() + StandardFrameConstants::kMarkerOffset - 3 *
kPointerSize);
On 2013/02/04 08:54:26, mvstanton wrote:
> A StubFailureTrampolineFrameConstant would be a nice aid for this expression.

Done.

https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32....
src/ia32/code-stubs-ia32.cc:7639: 2 * kPointerSize));
On 2013/02/04 08:54:26, mvstanton wrote:
> Would it make sense to having something like a
> StubFailureTrampolineConstants::kArgumentCountOffset for this expression?

Done.

[Michael Starzinger, 2013-02-04 16:05:10]

Drive-by comments.

https://codereview.chromium.org/12093089/diff/9003/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/12093089/diff/9003/src/frames.cc#newcode1328
src/frames.cc:1328: StubFailureTrampolineStub(i).FindCodeInCache(&trampoline,
isolate());
Are we sure that this stub is in the cache? We should set the IsPregenerated
flag for these stubs to true and see if it trips any of our assertions.