Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12093083: Temporarily makes use_aura the default on windows so we can get perf (Closed)

Created:
7 years, 10 months ago by sky
Modified:
7 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Temporarily makes use_aura the default on windows so we can get perf numbers. Will revert as soon as perf bots cycle. BUG=none TEST=none R=jbates@chromium.org,piman@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180308

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge to trunk and remove frame_rate_tests change (landed separately) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
The plan with this is to land it at an off peak time let it ...
7 years, 10 months ago (2013-01-31 05:05:37 UTC) #1
piman
lgtm
7 years, 10 months ago (2013-01-31 05:20:49 UTC) #2
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-01-31 16:58:43 UTC) #3
jbates
7 years, 10 months ago (2013-01-31 17:08:39 UTC) #4
LGTM

https://codereview.chromium.org/12093083/diff/1/chrome/test/perf/frame_rate/f...
File chrome/test/perf/frame_rate/frame_rate_tests.cc (right):

https://codereview.chromium.org/12093083/diff/1/chrome/test/perf/frame_rate/f...
chrome/test/perf/frame_rate/frame_rate_tests.cc:148: if (HasFlag(kUseGpu) &&
!IsGpuAvailable()) {
If this Aura run is meant to stay, best to put the check here and cancel the
test (it runs in both GPU and software modes, so this will just skip the
software run):
#if defined(USE_AURA)
if (!HasFlag(kUseGpu)) {
 printf("Test skipped, Aura always runs with GPU\n");
 return;
}

Powered by Google App Engine
This is Rietveld 408576698