Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: pkg/unittest/lib/html_individual_config.dart

Issue 12093076: Addressed Martin's comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_individual_config.dart
diff --git a/pkg/unittest/lib/html_individual_config.dart b/pkg/unittest/lib/html_individual_config.dart
index 14084211d8fe569b1b8dcd646a2aacb7c9d3681e..f722a6d3e5cd761930244bdaefcd97f88aac41d7 100644
--- a/pkg/unittest/lib/html_individual_config.dart
+++ b/pkg/unittest/lib/html_individual_config.dart
@@ -25,14 +25,13 @@ class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
void onStart() {
var testGroupName = window.location.search;
- var groupVar = 'group=';
- if (testGroupName != '' && testGroupName.contains(groupVar)) {
+ if (testGroupName != '') {
try {
- testGroupName = testGroupName.substring(
- testGroupName.indexOf(groupVar) + groupVar.length);
- var endIndex = testGroupName.indexOf('&');
- testGroupName = testGroupName.substring(0,
- endIndex == -1 ? testGroupName.length : endIndex);
+ for (var parameter in testGroupName.substring(1).split('&')) {
+ if (parameter.startsWith('group=')) {
+ testGroupName = parameter.split('=')[1];
+ }
+ }
unittest.filterTests('^$testGroupName${unittest.groupSep}');
} catch (e) {
print('tried to match "$testGroupName"');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698