Move the panel to the root window where the mouse click occurred.

ash/launcher/launcher_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_LAUNCHER_LAUNCHER_UTIL_H_
 #define ASH_LAUNCHER_LAUNCHER_UTIL_H_
 
 #include "ash/ash_export.h"
 
+namespace aura {
+class Window;
+}
+
+namespace ui {
+class Event;
+}
+
 namespace ash {
 class LauncherModel;
 
 namespace launcher {
 
 // Return the index of the browser item from a given |launcher_model|.
 ASH_EXPORT int GetBrowserItemIndex(const LauncherModel& launcher_model);
 
+// Move the maybe_panel to the root window where the |event| occured if

[sky, 2013/01/31 22:31:45]

|maybe_panel|

[oshima, 2013/01/31 23:16:54]

Done.

+// |maybe_panel| is of aura::client::WINDOW_TYPE_PANEL and it's not
+// in the same root window.
+ASH_EXPORT void MoveToEventRootIfPanel(aura::Window* maybe_panel,
+                                       const ui::Event& event);

[stevenjb, 2013/01/31 20:23:40]

nit: I would consider either:
a) require maybe_panel be a panel and remove the if/maybe
b) make this more generic, like 'MaybeMoveToEventRoot' with a note in the
comment that currently this only affects panels.

[oshima, 2013/01/31 20:37:41]

I intentionally included if/panel logic so that ash_unittests can
test the logic that is used by chrome. I tried to write another test
on chrome side, but it turns out that it's more complicated than that.
I agree that this is a bit ugly, but a compromise to increase the coverage.

I'm planning to clean up this once new launcher is completed though.
Clicking other items (apps, browser window) shouldn't move the window,
(plus, I'll most likely remove this when I clean up), so I'd like to keep it as
is.

+
 }  // namespace launcher
 }  // namespace ash
 
 #endif  // ASH_LAUNCHER_LAUNCHER_UTIL_H_