Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: runtime/bin/dartutils.h

Issue 12093071: - Change the layout of external typed array objects to avoid the extra indirection when accessing e… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/dartutils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dartutils.h
===================================================================
--- runtime/bin/dartutils.h (revision 17875)
+++ runtime/bin/dartutils.h (working copy)
@@ -228,10 +228,9 @@
static Dart_CObject* NewString(const char* str);
static Dart_CObject* NewArray(int length);
static Dart_CObject* NewUint8Array(int length);
- static Dart_CObject* NewExternalUint8Array(int64_t length,
- uint8_t* data,
- void* peer,
- Dart_PeerFinalizer callback);
+ static Dart_CObject* NewExternalUint8Array(
+ int64_t length, uint8_t* data, void* peer,
+ Dart_WeakPersistentHandleFinalizer callback);
static Dart_CObject* NewIOBuffer(int64_t length);
static void FreeIOBufferData(Dart_CObject* object);
@@ -412,7 +411,7 @@
}
uint8_t* Data() const { return cobject_->value.as_external_byte_array.data; }
void* Peer() const { return cobject_->value.as_external_byte_array.peer; }
- Dart_PeerFinalizer Callback() const {
+ Dart_WeakPersistentHandleFinalizer Callback() const {
return cobject_->value.as_external_byte_array.callback;
}
« no previous file with comments | « no previous file | runtime/bin/dartutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698