- Change the layout of external typed array objects to avoid the extra indirection when accessing e…

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 943 matching lines @@
   return false;
 }
 
 
 bool Intrinsifier::ExternalUint8Array_getIndexed(Assembler* assembler) {
   Label fall_through;
   TestByteArrayGetIndex(assembler, &fall_through);
   // R12: index as Smi.
   // RAX: array.
   __ SmiUntag(R12);
-  __ movq(RAX, FieldAddress(RAX, ExternalUint8Array::external_data_offset()));
-  __ movq(RAX, Address(RAX, ExternalByteArrayData<uint8_t>::data_offset()));
+  __ movq(RAX, FieldAddress(RAX, ExternalUint8Array::data_offset()));
   __ movzxb(RAX, Address(RAX, R12, TIMES_1, 0));
   __ SmiTag(RAX);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in RAX.
@@ skipping 745 matching lines @@
   __ LoadObject(RAX, Bool::True());
   __ ret();
   return true;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64