- Change the layout of external typed array objects to avoid the extra indirection when accessing e…

runtime/include/dart_api.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef INCLUDE_DART_API_H_
 #define INCLUDE_DART_API_H_
 
 /** \mainpage Dart Embedding API Reference
  *
  * Dart is a class-based programming language for creating structured
@@ skipping 940 matching lines @@
       struct _Dart_CObject** values;
     } as_array;
     struct {
       int length;
       uint8_t* values;
     } as_byte_array;
     struct {
       int length;
       uint8_t* data;
       void* peer;
-      Dart_PeerFinalizer callback;
+      Dart_WeakPersistentHandleFinalizer callback;
     } as_external_byte_array;
   } value;
 } Dart_CObject;
 
 /**
  * Posts a message on some port. The message will contain the
  * Dart_CObject object graph rooted in 'message'.
  *
  * While the message is being sent the state of the graph of
  * Dart_CObject structures rooted in 'message' should not be accessed,
@@ skipping 685 matching lines @@
 DART_EXPORT Dart_Handle Dart_NewByteArray(intptr_t length);
 
 /**
  * Returns a ByteArray which references an external array of 8-bit bytes.
  *
  * \param value An array of 8-bit bytes. This array must not move.
  * \param length The length of the array.
  * \param peer An external pointer to associate with this byte array.
  *
  * \return The ByteArray object if no error occurs. Otherwise returns
- *   an error handle.
+ *   an error handle. The ByteArray object is returned in a
+ *   WeakPersistentHandle which needs to be deleted in the specified callback
+ *   using Dart_DeletePersistentHandle.
  */
-DART_EXPORT Dart_Handle Dart_NewExternalByteArray(uint8_t* data,
-                                                  intptr_t length,
-                                                  void* peer,
-                                                  Dart_PeerFinalizer callback);
+DART_EXPORT Dart_Handle Dart_NewExternalByteArray(
+    uint8_t* data,
+    intptr_t length,
+    void* peer,
+    Dart_WeakPersistentHandleFinalizer callback);
 
 /**
  * Returns a clamped ByteArray which references an external array of
  * 8-bit bytes.
  * A clamped ByteArray differs from ByteArray above in the indexed store
  * operation where negative values are clamped to 0 and values above 255 are
  * clamped to 255.
  *
  * \param value An array of 8-bit bytes. This array must not move.
  * \param length The length of the array.
  * \param peer An external pointer to associate with this byte array.
  *
  * \return The clamped ByteArray object if no error occurs. Otherwise returns
- *   an error handle.
+ *   an error handle. The clamped ByteArray object is returned in a
+ *   WeakPersistentHandle which needs to be deleted in the specified callback
+ *   using Dart_DeletePersistentHandle.
  */
 DART_EXPORT Dart_Handle Dart_NewExternalClampedByteArray(
     uint8_t* data,
     intptr_t length,
     void* peer,
-    Dart_PeerFinalizer callback);
+    Dart_WeakPersistentHandleFinalizer callback);
 
 /**
  * Retrieves the data pointer associated with an external ByteArray.
  */
 DART_EXPORT Dart_Handle Dart_ExternalByteArrayGetData(Dart_Handle object,
                                                       void** data);
 
 /**
  * Retrieves the peer pointer associated with an external ByteArray.
  */
@@ skipping 1124 matching lines @@
  *
  * \param object An object.
  * \param peer A value to store in the peer field.
  *
  * \return Returns an error if 'object' is a subtype of Null, num, or
  *   bool.
  */
 DART_EXPORT Dart_Handle Dart_SetPeer(Dart_Handle object, void* peer);
 
 #endif  // INCLUDE_DART_API_H_