Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: runtime/bin/io_buffer.cc

Issue 12093071: - Change the layout of external typed array objects to avoid the extra indirection when accessing e… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/io_buffer.h" 5 #include "bin/io_buffer.h"
6 6
7 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { 7 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
8 uint8_t* data = Allocate(size); 8 uint8_t* data = Allocate(size);
9 Dart_Handle result = Dart_NewExternalByteArray(data, size, data, Free); 9 Dart_Handle result = Dart_NewExternalByteArray(data, size,
10 data, IOBuffer::Finalizer);
10 if (Dart_IsError(result)) { 11 if (Dart_IsError(result)) {
11 Free(data); 12 Free(data);
12 Dart_PropagateError(result); 13 Dart_PropagateError(result);
13 } 14 }
14 if (buffer != NULL) { 15 if (buffer != NULL) {
15 *buffer = data; 16 *buffer = data;
16 } 17 }
17 return result; 18 return result;
18 } 19 }
19 20
20 uint8_t* IOBuffer::Allocate(intptr_t size) { 21 uint8_t* IOBuffer::Allocate(intptr_t size) {
21 return new uint8_t[size]; 22 return new uint8_t[size];
22 } 23 }
OLDNEW
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698