Issue 12093070: WebContentsVideoCaptureDevice: Recover after errors.

Issue 12093070: WebContentsVideoCaptureDevice: Recover after errors. (Closed)

Created:
7 years, 10 months ago by ncarter (slow)

Modified:
7 years, 10 months ago

Reviewers:
vrk (LEFT CHROMIUM), miu

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebContentsVideoCaptureDevice: Recover after errors. In RenderOnRenderThread, be sure to always run the callback, even when dropping frames. Without this fix, num_renders_pending_ would be stuck at 2 forever after two errors. Add a test demonstrating this bug. Also fixes tests to time out after 2 seconds of inactivity. TEST=new content_unittests BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180295

Patch Set 1 #

Patch Set 2 : Fix some whitespace. #

Patch Set 3 : More self-review fixes. #

Patch Set 4 : merge with upstream #

Patch Set 5 : Merge with upstream. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -4 lines)			Patch
	M	content/browser/renderer_host/media/web_contents_video_capture_device.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download
	M	content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc	View	1 2	8 chunks	+58 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/12093070/9001

7 years, 10 months ago (2013-02-02 23:49:22 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=80881

7 years, 10 months ago (2013-02-03 00:06:01 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/12093070/9001

7 years, 10 months ago (2013-02-03 05:25:01 UTC) #7

commit-bot: I haz the power

7 years, 10 months ago (2013-02-03 05:26:41 UTC) #8

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Expand Messages | Collapse Messages