chrome/browser/extensions/extension_info_map_unittest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_info_map_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_icon_manager_unittest.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_info_map_unittest.cc

diff --git a/chrome/browser/extensions/extension_info_map_unittest.cc b/chrome/browser/extensions/extension_info_map_unittest.cc

index 439e42a352013aa0e451380b871784e577394ef9..05ba73fe22253ded63cba820d62f1aa8a282f056 100644

--- a/chrome/browser/extensions/extension_info_map_unittest.cc

+++ b/chrome/browser/extensions/extension_info_map_unittest.cc

@@ -17,6 +17,7 @@

using content::BrowserThread;

using extensions::APIPermission;

using extensions::Extension;

+using extensions::Manifest;

using WebKit::WebSecurityOrigin;

using WebKit::WebString;

@@ -51,7 +52,7 @@ static scoped_refptr<Extension> CreateExtension(const std::string& name) {

std::string error;

scoped_refptr<Extension> extension = Extension::Create(

- path.AppendASCII(name), Extension::INVALID, manifest,

+ path.AppendASCII(name), Manifest::INVALID_LOCATION, manifest,

Extension::NO_FLAGS, &error);

EXPECT_TRUE(extension) << error;

@@ -73,7 +74,8 @@ static scoped_refptr<Extension> LoadManifest(const std::string& dir,

std::string error;

scoped_refptr<Extension> extension = Extension::Create(

- path, Extension::INVALID, *static_cast<DictionaryValue*>(result.get()),

+ path, Manifest::INVALID_LOCATION,

+ *static_cast<DictionaryValue*>(result.get()),

Extension::NO_FLAGS, &error);

EXPECT_TRUE(extension) << error;