chrome/browser/extensions/api/developer_private/developer_private_apitest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/discovery/discovery_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

index 3864e7cbec58577f625b761af8909b2e9664721b..52ec42601bcdccf850168b9e985079f60527b173 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

@@ -32,7 +32,7 @@ class DeveloperPrivateApiTest : public ExtensionApiTest {

void InstallNamedExtension(const FilePath& path,

const std::string& name,

- Extension::Location install_source) {

+ Manifest::Location install_source) {

const Extension* extension = InstallExtension(path.AppendASCII(name), 1,

install_source);

ASSERT_TRUE(extension);

@@ -46,9 +46,9 @@ IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, Basics) {

LoadExtensions();

FilePath basedir = test_data_dir_.AppendASCII("developer");

- InstallNamedExtension(basedir, "packaged_app", Extension::INTERNAL);

+ InstallNamedExtension(basedir, "packaged_app", Manifest::INTERNAL);

- InstallNamedExtension(basedir, "simple_extension", Extension::INTERNAL);

+ InstallNamedExtension(basedir, "simple_extension", Manifest::INTERNAL);

ASSERT_TRUE(RunExtensionSubtest(

"developer/test", "basics.html", kFlagLoadAsComponent));