Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

extensions/common/install_warning.h

Index: extensions/common/install_warning.h
diff --git a/extensions/common/install_warning.h b/extensions/common/install_warning.h
new file mode 100644
index 0000000000000000000000000000000000000000..a4772c431e14b77cf45543be401e6865a42b077a
--- /dev/null
+++ b/extensions/common/install_warning.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_COMMON_INSTALL_WARNING_H_
+#define EXTENSIONS_COMMON_INSTALL_WARNING_H_
+
+#include <string>
+#include <vector>
+
+namespace extensions {
+
+struct InstallWarning {
+  typedef std::vector<InstallWarning> Vector;

[Jeffrey Yasskin, 2013/01/29 22:54:07]

Is this typedef worth having? std::vector<InstallWarning> isn't much longer than
InstallWarning::Vector at all, and it's more obvious what type you get.

[Yoyo Zhou, 2013/01/30 01:16:01]

Might as well remove it.

+
+  enum Format {
+    // IMPORTANT: Do not build HTML strings from user or developer-supplied
+    // input.
+    FORMAT_TEXT,
+    FORMAT_HTML,
+  };
+  InstallWarning(Format format, const std::string& message)
+      : format(format), message(message) {
+  }
+  bool operator==(const InstallWarning& other) const {
+    return format == other.format && message == other.message;
+  }
+  Format format;
+  std::string message;
+};
+
+}  // namespace
+
+#endif  // EXTENSIONS_COMMON_INSTALL_WARNING_H_