chrome/common/extensions/extension_builder.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_builder.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.h ('K') | « chrome/common/extensions/extension_builder.h ('k') | chrome/common/extensions/extension_file_util.h » ('j') | chrome/common/extensions/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_builder.cc

diff --git a/chrome/common/extensions/extension_builder.cc b/chrome/common/extensions/extension_builder.cc

index 2a446075c73d669caf45be03cf22cf100e243977..93be0c5c2fc2173f119e27d0fa3fdebd1fdcd899 100644

--- a/chrome/common/extensions/extension_builder.cc

+++ b/chrome/common/extensions/extension_builder.cc

@@ -9,7 +9,7 @@

namespace extensions {

ExtensionBuilder::ExtensionBuilder()

- : location_(Extension::LOAD),

+ : location_(Manifest::LOAD),

flags_(Extension::NO_FLAGS) {

}

ExtensionBuilder::~ExtensionBuilder() {}

@@ -32,7 +32,7 @@ ExtensionBuilder& ExtensionBuilder::SetPath(const FilePath& path) {

return *this;

}

-ExtensionBuilder& ExtensionBuilder::SetLocation(Extension::Location location) {

+ExtensionBuilder& ExtensionBuilder::SetLocation(Manifest::Location location) {

location_ = location;

return *this;

}