Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/common/extensions/permissions/permission_set.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_
 #define CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
 #include "base/string16.h"
-#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
 #include "chrome/common/extensions/permissions/api_permission.h"
 #include "chrome/common/extensions/permissions/api_permission_set.h"
 #include "chrome/common/extensions/permissions/permission_message.h"
 #include "extensions/common/url_pattern_set.h"
 
 namespace extensions {
+class Extension;
 
 // The PermissionSet is an immutable class that encapsulates an
 // extension's permissions. The class exposes set operations for combining and
 // manipulating the permissions.
 class PermissionSet
     : public base::RefCountedThreadSafe<PermissionSet> {
  public:
   // Creates an empty permission set (e.g. default permissions).
   PermissionSet();
 
@@ skipping 39 matching lines @@
   std::set<std::string> GetAPIsAsStrings() const;
 
   // Returns whether this namespace has any functions which the extension has
   // permission to use.  For example, even though the extension may not have
   // the "tabs" permission, "tabs.create" requires no permissions so
   // HasAnyAccessToAPI("tabs") will return true.
   bool HasAnyAccessToAPI(const std::string& api_name) const;
 
   // Gets the localized permission messages that represent this set.
   // The set of permission messages shown varies by extension type.
-  PermissionMessages GetPermissionMessages(Extension::Type extension_type)
+  PermissionMessages GetPermissionMessages(Manifest::Type extension_type)
       const;
 
   // Gets the localized permission messages that represent this set (represented
   // as strings). The set of permission messages shown varies by extension type.
-  std::vector<string16> GetWarningMessages(Extension::Type extension_type)
+  std::vector<string16> GetWarningMessages(Manifest::Type extension_type)
       const;
 
   // Returns true if this is an empty set (e.g., the default permission set).
   bool IsEmpty() const;
 
   // Returns true if the set has the specified API permission.
   bool HasAPIPermission(APIPermission::ID permission) const;
 
   // Returns true if the set allows the given permission with the default
   // permission detal.
@@ skipping 98 matching lines @@
   // TODO(jstritar): Rename to "user_script_hosts_"?
   URLPatternSet scriptable_hosts_;
 
   // The list of hosts this effectively grants access to.
   URLPatternSet effective_hosts_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_