Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/tcmalloc/chromium/src/system-alloc.cc

Issue 12093035: TCMalloc: support userland ASLR on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address more comments by Chris. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/security_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2005, Google Inc. 1 // Copyright (c) 2005, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 // Check that no bit is set at position ADDRESS_BITS or higher. 93 // Check that no bit is set at position ADDRESS_BITS or higher.
94 template <int ADDRESS_BITS> bool CheckAddressBits(uintptr_t ptr) { 94 template <int ADDRESS_BITS> bool CheckAddressBits(uintptr_t ptr) {
95 return (ptr >> ADDRESS_BITS) == 0; 95 return (ptr >> ADDRESS_BITS) == 0;
96 } 96 }
97 97
98 // Specialize for the bit width of a pointer to avoid undefined shift. 98 // Specialize for the bit width of a pointer to avoid undefined shift.
99 template <> bool CheckAddressBits<8 * sizeof(void*)>(uintptr_t ptr) { 99 template <> bool CheckAddressBits<8 * sizeof(void*)>(uintptr_t ptr) {
100 return true; 100 return true;
101 } 101 }
102 102
103 // From libdieharder, public domain library by Bob Jenkins (rngav.c).
104 // Described at http://burtleburtle.net/bob/rand/smallprng.html.
105 // Not cryptographically secure, but good enough for what we need.
106 typedef uint32_t u4;
107 typedef struct ranctx { u4 a; u4 b; u4 c; u4 d; } ranctx;
108
109 #define rot(x,k) ((x<<(k))|(x>>(32-(k))))
110
111 static u4 ranval(ranctx* x) {
112 /* xxx: the generator being tested */
113 u4 e = x->a - rot(x->b, 27);
114 x->a = x->b ^ rot(x->c, 17);
115 x->b = x->c + x->d;
116 x->c = x->d + e;
117 x->d = e + x->a;
118 return x->d;
119 }
120
121 static u4 raninit(ranctx* x, u4 seed) {
122 u4 i, e;
123 x->a = x->b = x->c = 0xf1ea5eed;
124 x->d = seed - x->a;
125 for (i=0; i<20; ++i) {
126 e = ranval(x);
127 }
128 return e;
129 }
130
131 // End PRNG code.
132
133 #define ASLR_IS_SUPPORTED \\
134 (defined(OS_LINUX) || defined(OS_CHROMEOS)) && defined(__x86_64__)
135
136 // Give a random "hint" that is suitable for use with mmap(). This cannot make
137 // mmap fail , as the kernel will simply not follow the hint if it can't.
138 // However, this will create address space fragmentation. Currently, we only
139 // implement it on x86_64, where we have a 47 bits userland address space and
140 // fragmentation is not an issue.
141 void* GetRandomAddrHint() {
142 #if defined(ASLR_IS_SUPPORTED)
143 // Note: we are protected by the general TCMalloc_SystemAlloc spinlock. Given
144 // the nature of what we're doing, it wouldn't be critical if we weren't.
145 // It's nice to share the state between threads, because scheduling will add
146 // some randomness to the succession of ranval() calls.
147 static ranctx ctx;
148 static bool initialized = false;
149 if (!initialized) {
150 volatile char c;
151 // Pre-initialize our seed with a "random" address in case /dev/urandom is
152 // not available.
153 uint32_t seed = (reinterpret_cast<uint64_t>(&c) >> 32) |
154 reinterpret_cast<uint64_t>(&c);
155 int urandom_fd = open("/dev/urandom", O_RDONLY);
156 ASSERT(urandom_fd >= 0);
157 if (urandom_fd >= 0) {
158 ssize_t len;
159 len = read(urandom_fd, &seed, sizeof(seed));
160 ASSERT(len == sizeof(seed));
161 ASSERT(close(urandom_fd) == 0);
Chris Evans 2013/01/29 06:56:35 Dunno why but I'm still not comfortable relying up
162 }
163 raninit(&ctx, seed);
164 initialized = true;
165 }
166 uint64_t random_address = static_cast<uint64_t>(ranval(&ctx)) << 32 |
167 ranval(&ctx);
168 // If the kernel cannot honor the hint in arch_get_unmapped_area_topdown, it
169 // will simply ignore it. So we give a hint that has a good chance of
170 // working.
171 // The mmap top-down allocator will normally allocate below TASK_SIZE - gap,
172 // with a gap that depends on the max stack size. See x86/mm/mmap.c. We
173 // should make allocations that are below this area, which would be
174 // 0x7ffbf8000000.
175 // We use 0x3ffffffff000 as the mask so that we only "pollute" half of the
176 // address space. In the unlikely case where fragmentation would become an
177 // issue, the kernel will still have another half to use.
178 // A a bit-wise "and" won't bias our random distribution.
179 random_address &= 0x3ffffffff000ULL;
180 return reinterpret_cast<void*>(random_address);
181 #else
182 return NULL;
183 #endif // ASLR_IS_SUPPORTED
184 }
185
103 } // Anonymous namespace to avoid name conflicts on "CheckAddressBits". 186 } // Anonymous namespace to avoid name conflicts on "CheckAddressBits".
104 187
105 COMPILE_ASSERT(kAddressBits <= 8 * sizeof(void*), 188 COMPILE_ASSERT(kAddressBits <= 8 * sizeof(void*),
106 address_bits_larger_than_pointer_size); 189 address_bits_larger_than_pointer_size);
107 190
108 // Structure for discovering alignment 191 // Structure for discovering alignment
109 union MemoryAligner { 192 union MemoryAligner {
110 void* p; 193 void* p;
111 double d; 194 double d;
112 size_t s; 195 size_t s;
(...skipping 19 matching lines...) Expand all
132 EnvToInt("TCMALLOC_DEVMEM_LIMIT", 0), 215 EnvToInt("TCMALLOC_DEVMEM_LIMIT", 0),
133 "Physical memory limit location in MB for /dev/mem allocation." 216 "Physical memory limit location in MB for /dev/mem allocation."
134 " Setting this to 0 means no limit."); 217 " Setting this to 0 means no limit.");
135 DEFINE_bool(malloc_skip_sbrk, 218 DEFINE_bool(malloc_skip_sbrk,
136 EnvToBool("TCMALLOC_SKIP_SBRK", false), 219 EnvToBool("TCMALLOC_SKIP_SBRK", false),
137 "Whether sbrk can be used to obtain memory."); 220 "Whether sbrk can be used to obtain memory.");
138 DEFINE_bool(malloc_skip_mmap, 221 DEFINE_bool(malloc_skip_mmap,
139 EnvToBool("TCMALLOC_SKIP_MMAP", false), 222 EnvToBool("TCMALLOC_SKIP_MMAP", false),
140 "Whether mmap can be used to obtain memory."); 223 "Whether mmap can be used to obtain memory.");
141 224
225 DEFINE_bool(malloc_random_allocator,
226 EnvToBool("TCMALLOC_ASLR",
227 #if defined(ASLR_IS_SUPPORTED)
228 true),
229 #else
230 false),
231 #endif
232 "Whether to randomize the address space via mmap().");
233
142 // static allocators 234 // static allocators
143 class SbrkSysAllocator : public SysAllocator { 235 class SbrkSysAllocator : public SysAllocator {
144 public: 236 public:
145 SbrkSysAllocator() : SysAllocator() { 237 SbrkSysAllocator() : SysAllocator() {
146 } 238 }
147 void* Alloc(size_t size, size_t *actual_size, size_t alignment); 239 void* Alloc(size_t size, size_t *actual_size, size_t alignment);
148 }; 240 };
149 static char sbrk_space[sizeof(SbrkSysAllocator)]; 241 static char sbrk_space[sizeof(SbrkSysAllocator)];
150 242
151 class MmapSysAllocator : public SysAllocator { 243 class MmapSysAllocator : public SysAllocator {
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 // Ask for extra memory if alignment > pagesize 389 // Ask for extra memory if alignment > pagesize
298 size_t extra = 0; 390 size_t extra = 0;
299 if (alignment > pagesize) { 391 if (alignment > pagesize) {
300 extra = alignment - pagesize; 392 extra = alignment - pagesize;
301 } 393 }
302 394
303 // Note: size + extra does not overflow since: 395 // Note: size + extra does not overflow since:
304 // size + alignment < (1<<NBITS). 396 // size + alignment < (1<<NBITS).
305 // and extra <= alignment 397 // and extra <= alignment
306 // therefore size + extra < (1<<NBITS) 398 // therefore size + extra < (1<<NBITS)
307 void* result = mmap(NULL, size + extra, 399 void* address_hint = NULL;
400 if (FLAGS_malloc_random_allocator) {
401 address_hint = GetRandomAddrHint();
402 }
403 void* result = mmap(address_hint, size + extra,
308 PROT_READ|PROT_WRITE, 404 PROT_READ|PROT_WRITE,
309 MAP_PRIVATE|MAP_ANONYMOUS, 405 MAP_PRIVATE|MAP_ANONYMOUS,
310 -1, 0); 406 -1, 0);
311 if (result == reinterpret_cast<void*>(MAP_FAILED)) { 407 if (result == reinterpret_cast<void*>(MAP_FAILED)) {
312 return NULL; 408 return NULL;
313 } 409 }
314 410
315 // Adjust the return memory so it is aligned 411 // Adjust the return memory so it is aligned
316 uintptr_t ptr = reinterpret_cast<uintptr_t>(result); 412 uintptr_t ptr = reinterpret_cast<uintptr_t>(result);
317 size_t adjust = 0; 413 size_t adjust = 0;
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 failed_[i] = false; 534 failed_[i] = false;
439 } 535 }
440 return NULL; 536 return NULL;
441 } 537 }
442 538
443 static bool system_alloc_inited = false; 539 static bool system_alloc_inited = false;
444 void InitSystemAllocators(void) { 540 void InitSystemAllocators(void) {
445 MmapSysAllocator *mmap = new (mmap_space) MmapSysAllocator(); 541 MmapSysAllocator *mmap = new (mmap_space) MmapSysAllocator();
446 SbrkSysAllocator *sbrk = new (sbrk_space) SbrkSysAllocator(); 542 SbrkSysAllocator *sbrk = new (sbrk_space) SbrkSysAllocator();
447 543
544 DefaultSysAllocator *sdef = new (default_space) DefaultSysAllocator();
545
546 // Unfortunately, this code runs before flags are initialized. So
547 // we can't use FLAGS_malloc_random_allocator.
548 #if defined(ASLR_IS_SUPPORTED)
549 // Our only random allocator is mmap.
550 sdef->SetChildAllocator(mmap, 0, mmap_name);
551 #else
448 // In 64-bit debug mode, place the mmap allocator first since it 552 // In 64-bit debug mode, place the mmap allocator first since it
449 // allocates pointers that do not fit in 32 bits and therefore gives 553 // allocates pointers that do not fit in 32 bits and therefore gives
450 // us better testing of code's 64-bit correctness. It also leads to 554 // us better testing of code's 64-bit correctness. It also leads to
451 // less false negatives in heap-checking code. (Numbers are less 555 // less false negatives in heap-checking code. (Numbers are less
452 // likely to look like pointers and therefore the conservative gc in 556 // likely to look like pointers and therefore the conservative gc in
453 // the heap-checker is less likely to misinterpret a number as a 557 // the heap-checker is less likely to misinterpret a number as a
454 // pointer). 558 // pointer).
455 DefaultSysAllocator *sdef = new (default_space) DefaultSysAllocator();
456 if (kDebugMode && sizeof(void*) > 4) { 559 if (kDebugMode && sizeof(void*) > 4) {
457 sdef->SetChildAllocator(mmap, 0, mmap_name); 560 sdef->SetChildAllocator(mmap, 0, mmap_name);
458 sdef->SetChildAllocator(sbrk, 1, sbrk_name); 561 sdef->SetChildAllocator(sbrk, 1, sbrk_name);
459 } else { 562 } else {
460 sdef->SetChildAllocator(sbrk, 0, sbrk_name); 563 sdef->SetChildAllocator(sbrk, 0, sbrk_name);
461 sdef->SetChildAllocator(mmap, 1, mmap_name); 564 sdef->SetChildAllocator(mmap, 1, mmap_name);
462 } 565 }
566 #endif // ASLR_IS_SUPPORTED
463 sys_alloc = sdef; 567 sys_alloc = sdef;
464 } 568 }
465 569
466 void* TCMalloc_SystemAlloc(size_t size, size_t *actual_size, 570 void* TCMalloc_SystemAlloc(size_t size, size_t *actual_size,
467 size_t alignment) { 571 size_t alignment) {
468 // Discard requests that overflow 572 // Discard requests that overflow
469 if (size + alignment < size) return NULL; 573 if (size + alignment < size) return NULL;
470 574
471 SpinLockHolder lock_holder(&spinlock); 575 SpinLockHolder lock_holder(&spinlock);
472 576
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 } 644 }
541 } 645 }
542 #endif 646 #endif
543 } 647 }
544 648
545 void TCMalloc_SystemCommit(void* start, size_t length) { 649 void TCMalloc_SystemCommit(void* start, size_t length) {
546 // Nothing to do here. TCMalloc_SystemRelease does not alter pages 650 // Nothing to do here. TCMalloc_SystemRelease does not alter pages
547 // such that they need to be re-committed before they can be used by the 651 // such that they need to be re-committed before they can be used by the
548 // application. 652 // application.
549 } 653 }
OLDNEW
« no previous file with comments | « base/security_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698