sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 12093019: Support type variables on redirecting factory constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 12093019: Support type variables on redirecting factory constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index a8fa3005e1c3b1369652525770d18df759c26c2f..6c223dbd1c2a43c2e506aa9ca4795f5088b44c33 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -2248,10 +2248,6 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {

Diagnostic.INFO);

}

Element redirectionTarget = resolveRedirectingFactory(node);

- var type = mapping.getType(node.expression);

- if (type is InterfaceType && !type.isRaw) {

- unimplemented(node.expression, 'type arguments on redirecting factory');

- }

useElement(node.expression, redirectionTarget);

FunctionElement constructor = enclosingElement;

if (constructor.modifiers.isConst() &&

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')