Issue 12093013: Revert 179097 googleurl.gyp include_dir escapes src and is breaking android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12093013: Revert 179097 googleurl.gyp include_dir escapes src and is breaking android build. (Closed)

Created:
7 years, 11 months ago by boliu

Modified:
7 years, 11 months ago

Reviewers:
tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 179097 googleurl.gyp include_dir escapes src and is breaking android build. > Reland r179081 (Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/googleurl/googleurl.gyp). > > R=rsleevi@chromium.org > TBR=rsleevi@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12077023 TBR=tfarina@chromium.org,rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179104

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -31 lines)			Patch
M	build/all.gyp	View	13 chunks	+18 lines, -18 lines	0 comments	Download
M	build/temp_gyp/googleurl.gyp	View	2 chunks	+93 lines, -6 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)