Issue 12093012: Clean up of url data manager classes in content: move URLDataSourceImpl to its own file, move all t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12093012: Clean up of url data manager classes in content: move URLDataSourceImpl to its own file, move all t… (Closed)

Created:
7 years, 11 months ago by jam

Modified:
7 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Clean up of url data manager classes in content: move URLDataSourceImpl to its own file, move all the code to the content namespace, and remove the "Chrome" prefix from classes. TBR=scottmg BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179096

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+314 lines, -615 lines)			Patch
M	content/browser/browser_main_loop.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/resource_context_impl.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/resource_context_impl.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/storage_partition_impl_map.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/webui/url_data_manager.h	View	3 chunks	+15 lines, -100 lines	0 comments	Download
M	content/browser/webui/url_data_manager.cc	View	6 chunks	+21 lines, -71 lines	0 comments	Download
M	content/browser/webui/url_data_manager_backend.h	View	2 chunks	+15 lines, -16 lines	0 comments	Download
M	content/browser/webui/url_data_manager_backend.cc	View	19 chunks	+28 lines, -25 lines	0 comments	Download
A	content/browser/webui/url_data_source_impl.h	View	1 chunk	+97 lines, -0 lines	0 comments	Download
A	content/browser/webui/url_data_source_impl.cc	View	1 chunk	+59 lines, -0 lines	0 comments	Download
D	content/browser/webui/web_ui_data_source.h	View	1 chunk	+0 lines, -107 lines	0 comments	Download
D	content/browser/webui/web_ui_data_source.cc	View	1 chunk	+0 lines, -217 lines	0 comments	Download
A +	content/browser/webui/web_ui_data_source_impl.h	View	5 chunks	+17 lines, -17 lines	0 comments	Download
A +	content/browser/webui/web_ui_data_source_impl.cc	View	8 chunks	+45 lines, -46 lines	0 comments	Download
M	content/browser/webui/web_ui_data_source_unittest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/public/browser/url_data_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages