Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1209293004: WIP - improve ScrollableArea handling. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

WIP - improve ScrollableArea handling. Experiment-ful CL, using Mac Oilpan bots to try debug Mac-specific Oilpan crash. Final version that's for review: https://codereview.chromium.org/1215973002/

Patch Set 1 #

Patch Set 2 : mac compile fix #

Patch Set 3 : remove unregistration entirely #

Patch Set 4 : enable PinchViewport tests again #

Patch Set 5 : experiment over, back to prefinalizer #

Patch Set 6 : add missing scrollbar disconnect calls #

Patch Set 7 : disconnect local scrollbars #

Patch Set 8 : Move theme unregistration into prefinalizer #

Patch Set 9 : always clear out delegates (experiment) #

Patch Set 10 : always clear out delegates (experiment 2) #

Patch Set 11 : another take; insist on eager FrameView finalization #

Patch Set 12 : drop redundant scrollbar removal #

Patch Set 13 : eagerly dispose of scroll animators on FrameView #

Patch Set 14 : Dispose old FrameView upon clearing #

Patch Set 15 : try to understand parameterized tests and GC behavior.. #

Patch Set 16 : move ScrollableArea to the heap #

Patch Set 17 : re-enable more unit tests #

Patch Set 18 : revert local scrollbar disconnect #

Patch Set 19 : move ScrollingCoordinator to the heap also #

Patch Set 20 : non-oilpan compile fix #

Patch Set 21 : non-oilpan compile fix #

Patch Set 22 : eagerly finalize viewport scrollable areas #

Patch Set 23 : simplify eager finalization decls #

Patch Set 24 : add asserts to flush out null access.. #

Patch Set 25 : tidying #

Patch Set 26 : temp disable root layer scroll tests #

Patch Set 27 : temp disable root layer scroll test over WebFrameResizeTest #

Patch Set 28 : revert temp. root layer scroll unit test disabling #

Patch Set 29 : scrollToAnchor(): defend against detached frames..just in case. #

Patch Set 30 : fix component build #

Patch Set 31 : undo accidental ScrollAnimatorMac change #

Patch Set 32 : yet another experiment - theme-unregister scrollbars during disconnect #

Patch Set 33 : undo experiment - had no bearing #

Patch Set 34 : add layoutViewportScrollableArea() non-null assert #

Patch Set 35 : clear out animators on DeprecatedPaintLayerScrollableArea dispose #

Patch Set 36 : rebased #

Patch Set 37 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -243 lines) Patch
M Source/core/frame/FrameHost.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameHost.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 36 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 36 8 chunks +10 lines, -5 lines 0 comments Download
M Source/core/frame/PinchViewport.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 36 2 chunks +9 lines, -8 lines 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 36 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/frame/RootFrameViewport.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 22 36 2 chunks +10 lines, -7 lines 0 comments Download
M Source/core/frame/RootFrameViewport.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/RootFrameViewportTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 18 chunks +122 lines, -107 lines 0 comments Download
M Source/core/input/EventHandler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 36 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 36 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 36 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 36 2 chunks +11 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 4 chunks +19 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 36 4 chunks +22 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 2 chunks +16 lines, -5 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 9 10 24 25 26 27 28 29 30 31 32 33 36 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollAnimator.h View 36 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.cpp View 36 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 36 5 chunks +18 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 36 2 chunks +8 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableAreaTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 3 chunks +17 lines, -6 lines 0 comments Download
M Source/platform/scroll/Scrollbar.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 36 3 chunks +7 lines, -9 lines 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 32 36 2 chunks +5 lines, -20 lines 0 comments Download
M Source/web/ViewportAnchor.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 2 3 15 26 27 36 2 chunks +0 lines, -6 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 36 7 chunks +35 lines, -24 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +0 lines, -12 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698