net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem - Issue 1209283004: Implement VerifySignedData() for ECDSA, RSA PKCS#1 and RSA PSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem

Issue 1209283004: Implement VerifySignedData() for ECDSA, RSA PKCS#1 and RSA PSS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@parse_pss

Patch Set: add a test for non-BIT STRING signature value Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/verify_signed_data.cc ('K') | « net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512.pem ('k') | net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-spki-params-null.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem

diff --git a/net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem b/net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem

new file mode 100644

index 0000000000000000000000000000000000000000..1a78bbfc95a61d5b3986954f80a2f8489ea8d529

--- /dev/null

+++ b/net/data/verify_signed_data_unittest/ecdsa-prime256v1-sha512-signature-not-bitstring.pem

@@ -0,0 +1,42 @@

+This is the same test as ecdsa-prime256v1-sha512.pem, except the signature

+value is not wrapped in a BIT STRING and is just the straight up

+Ecdsa-Sig-Value.

+This should fail to verify since the expectation is that the signature be a BIT STRING.

+$ openssl asn1parse -i < [PUBLIC KEY]

+ 0:d=0 hl=2 l= 89 cons: SEQUENCE

+ 2:d=1 hl=2 l= 19 cons: SEQUENCE

+ 4:d=2 hl=2 l= 7 prim: OBJECT :id-ecPublicKey

+ 13:d=2 hl=2 l= 8 prim: OBJECT :prime256v1

+ 23:d=1 hl=2 l= 66 prim: BIT STRING

+-----BEGIN PUBLIC KEY-----

+MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEnLDPaTA9r8dh1ORoe07PA55tNKuWSvgIENjVWKS

+o1vctUSM6F4iSCobuCKGWLHnvoxf7eHnil9rSFG25lfoceA==

+-----END PUBLIC KEY-----

+$ openssl asn1parse -i < [ALGORITHM]

+ 0:d=0 hl=2 l= 10 cons: SEQUENCE

+ 2:d=1 hl=2 l= 8 prim: OBJECT :ecdsa-with-SHA512

+-----BEGIN ALGORITHM-----

+MAoGCCqGSM49BAME

+-----END ALGORITHM-----

+-----BEGIN DATA-----

+bikyFTMBpO72gOZCiSmtrpiMEI1mijH/VdBImUfXX/gaRr+J6E1kAfAjvm6HaI+814TXhcqEZzV

+SSstS0ARSyEBApHnnzDMJNkQdk7vnIqlDKm4dsRK1yUA7ECcssTR/1hnUY/ep0iOtdv3gbYpog1

+APuEMjWr/5jiQb37VTjD4=

+-----END DATA-----

+$ openssl asn1parse -i < [SIGNATURE]

+ 0:d=0 hl=2 l= 68 cons: SEQUENCE

+ 2:d=1 hl=2 l= 32 prim: INTEGER :4B9F91E4285287261A1D1C923CF619CD52C175CFE7F1BE60A5258C610348BA3D

+ 36:d=1 hl=2 l= 32 prim: INTEGER :28C45F901D71C41B298638EC0D6A85D7FCB0C33BBFEC5A9C810846B639289A84

+-----BEGIN SIGNATURE-----

+MEQCIEufkeQoUocmGh0ckjz2Gc1SwXXP5/G+YKUljGEDSLo9AiAoxF+QHXHEGymGOOwNaoXX/LD

+DO7/sWpyBCEa2OSiahA==

+-----END SIGNATURE-----