Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1209253006: Need to update first-line when font finish loading. (Closed)

Created:
5 years, 6 months ago by rune
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Need to update first-line when font finish loading. Another regression from baseLayoutStyle implementation where operator== is not affected by the loading/loaded state of web fonts. To get a re- layout and re-rendering when a web font loading state changes, we need to check for the loading state. In this case, there was a missing check for ::first-line pseudo style. Also, moved the code which marks for re-layout with accompanying FIXME into LayoutObject. BUG=501564, 504864 TEST=fast/text/ellipsis-platform-font-change.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198048

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Mark test for rebaselining #

Total comments: 4

Patch Set 4 : Review issue fix and virtual suite rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +5 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
h.joshi@: can you take a look the image failures in linux/win/mac_blink_rel and see if it ...
5 years, 5 months ago (2015-06-29 20:56:57 UTC) #2
h.joshi
@rune: checked new images for "ellipsis-platform-font-change.html" in linux/win/mac_blink_rel bots. Now correct images are generated and ...
5 years, 5 months ago (2015-06-30 04:02:25 UTC) #3
rune
On 2015/06/30 04:02:25, h.joshi wrote: > @rune: checked new images for "ellipsis-platform-font-change.html" in > linux/win/mac_blink_rel ...
5 years, 5 months ago (2015-06-30 07:58:01 UTC) #4
rune
5 years, 5 months ago (2015-06-30 08:09:15 UTC) #6
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/1209253006/diff/40001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/1209253006/diff/40001/Source/core/dom/Element.cpp#newcode1551 Source/core/dom/Element.cpp:1551: if (*oldPseudoStyle != *newPseudoStyle || oldPseudoStyle->font().loadingCustomFonts() != newPseudoStyle->font().loadingCustomFonts()) ...
5 years, 5 months ago (2015-06-30 08:25:22 UTC) #7
rune
https://codereview.chromium.org/1209253006/diff/40001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/1209253006/diff/40001/Source/core/dom/Element.cpp#newcode1551 Source/core/dom/Element.cpp:1551: if (*oldPseudoStyle != *newPseudoStyle || oldPseudoStyle->font().loadingCustomFonts() != newPseudoStyle->font().loadingCustomFonts()) { ...
5 years, 5 months ago (2015-06-30 09:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209253006/60001
5 years, 5 months ago (2015-06-30 09:41:11 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 10:47:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198048

Powered by Google App Engine
This is Rietveld 408576698