Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1209243004: Support disabling unit test batching. Use it for angle_end2end_tests (Closed)

Created:
5 years, 6 months ago by Paweł Hajdan Jr.
Modified:
5 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, piman+watch_chromium.org, Jamie Madill, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support disabling unit test batching. Use it for angle_end2end_tests This speeds up angle_end2end_tests 48s -> 12s on my Linux machine (4x). BUG=501604 Committed: https://crrev.com/915c316c3431e193be1b025c557b5eee557e22d0 Cr-Commit-Position: refs/heads/master@{#336546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M base/test/launcher/unit_test_launcher.h View 1 chunk +13 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 5 chunks +37 lines, -9 lines 0 comments Download
M gpu/angle_end2end_tests_main.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Paweł Hajdan Jr.
See https://codereview.chromium.org/1201583002 for context.
5 years, 6 months ago (2015-06-26 13:38:45 UTC) #2
Ken Russell (switch to Gerrit)
Thank you for adding this support. LGTM We'll make the same change to all of ...
5 years, 6 months ago (2015-06-26 15:38:09 UTC) #3
piman
lgtm
5 years, 5 months ago (2015-06-27 01:31:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209243004/1
5 years, 5 months ago (2015-06-29 10:46:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 11:49:26 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/915c316c3431e193be1b025c557b5eee557e22d0 Cr-Commit-Position: refs/heads/master@{#336546}
5 years, 5 months ago (2015-06-29 11:50:23 UTC) #8
Geoff Lang
It looks like this is causing angle_end2end_tests to fail on the Windows GPU FYI bots.
5 years, 5 months ago (2015-06-29 13:24:52 UTC) #9
Stephen White
5 years, 5 months ago (2015-06-29 17:41:48 UTC) #10
Message was sent while issue was closed.
On 2015/06/29 13:24:52, Geoff Lang wrote:
> It looks like this is causing angle_end2end_tests to fail on the Windows GPU
FYI
> bots.

Note: this patch was reverted in
https://chromium.googlesource.com/chromium/src.git/+/9dbed546384c617954e36ac7...
aka r336559 due to the above.

Powered by Google App Engine
This is Rietveld 408576698