Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 1209243003: Changed the constraints for hiding the top controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Used pollForUIThreadCriteria instead of pollForCriteria in the test code Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 9eda71ef9d393387f6d070acdc665576e6525c13..367e9f6f0b4f77753703ef8f76de51e29b24d0d8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -196,7 +196,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private boolean mIsClosing;
private boolean mIsShowingErrorPage;
- private boolean mIsImeShowing;
private Bitmap mFavicon;
@@ -521,9 +520,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
@Override
- public void onImeStateChangeRequested(boolean requestShow) {
+ public void onFocusedNodeEditabilityChanged(boolean editable) {
if (getFullscreenManager() == null) return;
- mIsImeShowing = requestShow;
updateFullscreenEnabledState();
}
}
@@ -1326,7 +1324,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mFullscreenHungRendererToken = FullscreenManager.INVALID_TOKEN;
mPreviousFullscreenOverdrawBottomHeight = Float.NaN;
}
- mIsImeShowing = false;
hideInternal();
@@ -2490,7 +2487,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
enableHidingTopControls &=
!AccessibilityUtil.isAccessibilityEnabled(getApplicationContext());
- enableHidingTopControls &= !mIsImeShowing;
+ enableHidingTopControls &= !mContentViewCore.isFocusedNodeEditable();
enableHidingTopControls &= !mIsShowingErrorPage;
enableHidingTopControls &= !webContents.isShowingInterstitialPage();
enableHidingTopControls &= (mFullscreenManager != null);
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698