Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java |
| index 1a5933485bfadc2b4125f5b4b18a6208adf49674..2069d4b831cc7ea8b1ae8b277e180b63f688af25 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java |
| @@ -189,7 +189,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener, |
| private boolean mIsClosing; |
| private boolean mIsShowingErrorPage; |
| - private boolean mIsImeShowing; |
| + private boolean mFocusedNodeEditable; |
|
jdduke (slow)
2015/07/01 16:02:04
Do we need to cache this? Can we just pull it from
raghu
2015/07/01 17:16:57
We can pull it from the |isFocusedNodeEditable()|
|
| private Bitmap mFavicon; |
| @@ -514,9 +514,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener, |
| } |
| @Override |
| - public void onImeStateChangeRequested(boolean requestShow) { |
| + public void onFocusedNodeEditabilityChanged(boolean editable) { |
| if (getFullscreenManager() == null) return; |
| - mIsImeShowing = requestShow; |
| + mFocusedNodeEditable = editable; |
| updateFullscreenEnabledState(); |
| } |
| } |
| @@ -1312,7 +1312,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener, |
| mFullscreenHungRendererToken = FullscreenManager.INVALID_TOKEN; |
| mPreviousFullscreenOverdrawBottomHeight = Float.NaN; |
| } |
| - mIsImeShowing = false; |
| + mFocusedNodeEditable = false; |
| hideInternal(); |
| @@ -2476,7 +2476,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener, |
| enableHidingTopControls &= |
| !AccessibilityUtil.isAccessibilityEnabled(getApplicationContext()); |
| - enableHidingTopControls &= !mIsImeShowing; |
| + enableHidingTopControls &= !mFocusedNodeEditable; |
| enableHidingTopControls &= !mIsShowingErrorPage; |
| enableHidingTopControls &= !webContents.isShowingInterstitialPage(); |
| enableHidingTopControls &= (mFullscreenManager != null); |