Issue 1209233002: Let's hide double.INFINITY a bit more, by providing cleaner APIs for the cases where we're currentl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1209233002: Let's hide double.INFINITY a bit more, by providing cleaner APIs for the cases where we're currentl… (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Let's hide double.INFINITY a bit more, by providing cleaner APIs for the cases where we're currently trying to use it. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a5c979f0d3c2bfb5e9074d4e565cb01b42f18888

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -26 lines)			Patch
M	sky/engine/core/painting/Size.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/examples/widgets/styled_text.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/home.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/rendering/block.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/rendering/box.dart	View	5 chunks	+24 lines, -7 lines	0 comments	Download
M	sky/sdk/lib/rendering/stack.dart	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	sky/sdk/lib/widgets/scaffold.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/tabs.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/tests/widgets/syncs1.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-26 00:27:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a5c979f0d3c2bfb5e9074d4e565cb01b42f18888 (presubmit successful).