Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/dom/scripts/htmleventgenerator.py

Issue 12092118: Change the way that events are annotated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_audio/dartium/web_audio_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmleventgenerator.py
diff --git a/tools/dom/scripts/htmleventgenerator.py b/tools/dom/scripts/htmleventgenerator.py
index 8c351a469e07caa8c716ab478a3ab822b9e85939..c6242c3c8309784ce5dc23c5caf1d14bf9ff8862 100644
--- a/tools/dom/scripts/htmleventgenerator.py
+++ b/tools/dom/scripts/htmleventgenerator.py
@@ -390,13 +390,14 @@ class HtmlEventGenerator(object):
for event_info in events:
(dom_name, html_name, event_type) = event_info
+ annotation_name = dom_name + 'Event'
# If we're using a different provider, then don't declare one.
if self._GetEventRedirection(interface, html_name, event_type):
continue
annotations = FormatAnnotationsAndComments(
- GetAnnotationsAndComments(library_name, interface.id, dom_name), ' ')
+ GetAnnotationsAndComments(library_name, interface.id, annotation_name), ' ')
blois 2013/02/01 22:12:55 line length
Andrei Mouravski 2013/02/04 16:03:12 Done.
members_emitter.Emit(
"\n"
@@ -416,6 +417,7 @@ class HtmlEventGenerator(object):
for event_info in events:
(dom_name, html_name, event_type) = event_info
getter_name = 'on%s%s' % (html_name[:1].upper(), html_name[1:])
+ annotation_name = 'on' + dom_name
# If the provider is declared elsewhere, point to that.
redirection = self._GetEventRedirection(interface, html_name, event_type)
@@ -425,7 +427,7 @@ class HtmlEventGenerator(object):
provider = html_name + 'Event'
annotations = FormatAnnotationsAndComments(
- GetAnnotationsAndComments(library_name, interface.id, dom_name), ' ')
+ GetAnnotationsAndComments(library_name, interface.id, annotation_name), ' ')
blois 2013/02/01 22:12:55 line length
Andrei Mouravski 2013/02/04 16:03:12 Done.
members_emitter.Emit(
"\n"
« no previous file with comments | « sdk/lib/web_audio/dartium/web_audio_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698