Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12092107: Only permit plug-in loads in the browser if the plug-in isn't blocked or the (Closed)

Created:
7 years, 10 months ago by Chris Evans
Modified:
7 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, stuartmorgan+watch_chromium.org, markusheintz_
Visibility:
Public.

Description

Only permit plug-in loads in the browser if the plug-in isn't blocked or the user has authorized it with a browser-mediated interaction. (Reland https://codereview.chromium.org/12086077 with Android test tweak) BUG=172573 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -51 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 6 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.h View 5 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 6 chunks +81 lines, -19 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 4 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/pepper_flash_settings_helper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 8 chunks +25 lines, -5 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 6 chunks +39 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M content/public/browser/plugin_service_filter.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Evans
(FYI -- relanding patch that was reverted due to Android test fail)
7 years, 10 months ago (2013-02-01 09:08:50 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-01 09:52:00 UTC) #2
jam
7 years, 10 months ago (2013-02-01 16:23:06 UTC) #3
On 2013/02/01 09:08:50, Chris Evans wrote:
> (FYI -- relanding patch that was reverted due to Android test fail)

rubberstamp lgtm

in the future, please first upload the reverted change without the fix, and then
reupload with the fix. that way it's easy to see what changed in the reland

Powered by Google App Engine
This is Rietveld 408576698