Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12092078: Move string_number_conversions to base/strings. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
nfullagar1
CC:
chromium-reviews
Visibility:
Public.

Description

Move string_number_conversions to base/strings. This only updates includes in base and keeps a forwarding header for now to keep the change under control. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181161

Patch Set 1 #

Patch Set 2 : merge, sort headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1085 lines) Patch
M base/base.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/location.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/mac/authorization_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/mac_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_freebsd.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/process_util_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_openbsd.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M base/string_number_conversions.h View 1 chunk +3 lines, -111 lines 0 comments Download
D base/string_number_conversions.cc View 1 chunk +0 lines, -498 lines 0 comments Download
D base/string_number_conversions_unittest.cc View 1 chunk +0 lines, -442 lines 0 comments Download
A + base/strings/string_number_conversions.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/strings/string_number_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/strings/string_number_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_timeouts.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/values_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/value_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/version.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/vlog.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Not high priority.
7 years, 10 months ago (2013-01-31 00:54:01 UTC) #1
nfullagar1
7 years, 10 months ago (2013-02-06 22:11:48 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698