Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 12092069: Merge 141252 (Closed)

Created:
8 years, 1 month ago by John Knottenbelt
Modified:
8 years, 1 month ago
Reviewers:
John Knottenbelt
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141252 BUG=163887 > [Chromium] Fix find in page rects for overflowing content. > https://bugs.webkit.org/show_bug.cgi?id=104924 > > Reviewed by Julien Chaffraix. > > If a div has overflowing content, we should only normalise its > coordinates against the renderview or the containing scrollable block. > > TEST=WebFrameTest.FindInPageMatchRects > > * src/FindInPageCoordinates.cpp: > (WebKit::enclosingScrollableAncestor): > Helper function to find the enclosing containing block with an overflow clip. > (WebKit::toNormalizedRect): > Pass in the container as an argument. > (WebKit::findInPageRectFromAbsoluteRect): > Compute the container for toNormalizedRect using enclosingScrollableAncestor. > * tests/WebFrameTest.cpp: > Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage. > * tests/data/find.html: > Add test case for <select> element. > * tests/data/find_in_page_frame.html: > Add test cases: > - Result 15, 16 tests that containing <div> with style float:left and > height:0px does not impact coordinate normalization. > - Result 17, 18 tests that matches with absolute positioning are normalized containing > relative positioned block, even if there is a closer parent block with overflow clip. > - Result 19 adds a test case for <select> element. > TBR=jknotten@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -22 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +32 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/FindInPageCoordinates.cpp View 2 chunks +21 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 3 chunks +17 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/data/find.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/data/find_in_page_frame.html View 3 chunks +44 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
John Knottenbelt
8 years, 1 month ago (2013-01-30 17:53:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698