Issue 12092064: Avoids crash in PCMWaveInAudioInputStream::WaveCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12092064: Avoids crash in PCMWaveInAudioInputStream::WaveCallback (Closed)

Created:
7 years, 10 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 10 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Avoids crash in PCMWaveInAudioInputStream::WaveCallback BUG=12092064 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180125

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	media/audio/win/wavein_input_win.h	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	media/audio/win/wavein_input_win.cc	View	1	4 chunks	+18 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

henrika (OOO until Aug 14)

Dale, this is the best I can think of based on my rather limited experience ...

7 years, 10 months ago (2013-01-30 09:55:23 UTC) #1

DaleCurtis

Hmm we can try this, but I don't think it will be sufficient, I think ...

7 years, 10 months ago (2013-01-30 19:19:25 UTC) #2

henrika (OOO until Aug 14)

Thanks Dale, sounds much better. PTAL.

7 years, 10 months ago (2013-01-31 08:56:35 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-01 08:06:22 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/12092064/4