Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chromeos/dbus/ibus/ibus_panel_service.cc

Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/ibus/ibus_panel_service.cc
diff --git a/chromeos/dbus/ibus/ibus_panel_service.cc b/chromeos/dbus/ibus/ibus_panel_service.cc
index 995bb8417609c810309697ad76c6e90bda618dbc..2b00d05cb349e3f9194d1d1bc871d09acd202323 100644
--- a/chromeos/dbus/ibus/ibus_panel_service.cc
+++ b/chromeos/dbus/ibus/ibus_panel_service.cc
@@ -213,8 +213,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
}
candidate_window_handler_->UpdateLookupTable(table, visible);
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles HideLookupTable method call from ibus-daemon.
@@ -224,8 +223,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
candidate_window_handler_->HideLookupTable();
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles UpdateAuxiliaryText method call from ibus-daemon.
@@ -249,8 +247,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
}
candidate_window_handler_->UpdateAuxiliaryText(text, visible);
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles HideAuxiliaryText method call from ibus-daemon.
@@ -260,8 +257,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
candidate_window_handler_->HideAuxiliaryText();
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles UpdatePreeditText method call from ibus-daemon.
@@ -290,8 +286,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
}
candidate_window_handler_->UpdatePreeditText(text, cursor_pos, visible);
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles HidePreeditText method call from ibus-daemon.
@@ -301,8 +296,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
return;
candidate_window_handler_->HidePreeditText();
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles RegisterProperties method call from ibus-daemon.
@@ -321,8 +315,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
}
property_handler_->RegisterProperties(properties);
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Handles UpdateProperty method call from ibus-daemon.
@@ -340,8 +333,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
}
property_handler_->UpdateProperty(property);
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
void SetCursorLocation(const ibus::Rect& cursor_location,
@@ -356,8 +348,7 @@ class IBusPanelServiceImpl : public IBusPanelService {
if (!property_handler_)
return;
- dbus::Response* response = dbus::Response::FromMethodCall(method_call);
- response_sender.Run(response);
+ response_sender.Run(dbus::Response::FromMethodCall(method_call));
}
// Called when the method call is exported.

Powered by Google App Engine
This is Rietveld 408576698