Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 12092045: Revert 179093 (Closed)

Created:
7 years, 10 months ago by markusheintz_
Modified:
7 years, 10 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, feature-media-reviews_chromium.org, markusheintz_
Visibility:
Public.

Description

Revert 179093 > Display a content settings icon in the location bar that indicates whether the current website accesses the mediastream (camera/micorphone) or whether mediastream access was blocked. By clicking on the icon users can open a bubble that allows them change the media setting for the current website. > > BUG=167263 > TEST=TabSpecificContentSettings* > TBR=pastarmovj@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11896028 TBR=markusheintz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -317 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings_unittest.cc View 8 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 9 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 4 chunks +2 lines, -137 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/ui/media_stream_infobar_delegate.cc View 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
markusheintz_
7 years, 10 months ago (2013-01-29 18:53:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698