Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: base/prefs/testing_pref_store.cc

Issue 12092021: Remove PersistentPrefStore::MarkNeedsEmptyValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some tests. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/testing_pref_store.h ('k') | base/values.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/testing_pref_store.h" 5 #include "base/prefs/testing_pref_store.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 TestingPrefStore::TestingPrefStore() 10 TestingPrefStore::TestingPrefStore()
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 void TestingPrefStore::SetValueSilently(const std::string& key, Value* value) { 46 void TestingPrefStore::SetValueSilently(const std::string& key, Value* value) {
47 prefs_.SetValue(key, value); 47 prefs_.SetValue(key, value);
48 } 48 }
49 49
50 void TestingPrefStore::RemoveValue(const std::string& key) { 50 void TestingPrefStore::RemoveValue(const std::string& key) {
51 if (prefs_.RemoveValue(key)) 51 if (prefs_.RemoveValue(key))
52 NotifyPrefValueChanged(key); 52 NotifyPrefValueChanged(key);
53 } 53 }
54 54
55 void TestingPrefStore::MarkNeedsEmptyValue(const std::string& key) {
56 }
57
58 bool TestingPrefStore::ReadOnly() const { 55 bool TestingPrefStore::ReadOnly() const {
59 return read_only_; 56 return read_only_;
60 } 57 }
61 58
62 PersistentPrefStore::PrefReadError TestingPrefStore::GetReadError() const { 59 PersistentPrefStore::PrefReadError TestingPrefStore::GetReadError() const {
63 return PersistentPrefStore::PREF_READ_ERROR_NONE; 60 return PersistentPrefStore::PREF_READ_ERROR_NONE;
64 } 61 }
65 62
66 PersistentPrefStore::PrefReadError TestingPrefStore::ReadPrefs() { 63 PersistentPrefStore::PrefReadError TestingPrefStore::ReadPrefs() {
67 NotifyInitializationCompleted(); 64 NotifyInitializationCompleted();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 return false; 123 return false;
127 124
128 return stored_value->GetAsBoolean(value); 125 return stored_value->GetAsBoolean(value);
129 } 126 }
130 127
131 void TestingPrefStore::set_read_only(bool read_only) { 128 void TestingPrefStore::set_read_only(bool read_only) {
132 read_only_ = read_only; 129 read_only_ = read_only;
133 } 130 }
134 131
135 TestingPrefStore::~TestingPrefStore() {} 132 TestingPrefStore::~TestingPrefStore() {}
OLDNEW
« no previous file with comments | « base/prefs/testing_pref_store.h ('k') | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698