Remove PersistentPrefStore::MarkNeedsEmptyValue.

base/prefs/json_pref_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/json_pref_store.h"
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 231 matching lines @@
 
   EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1);
   EXPECT_CALL(*mock_error_delegate,
               OnError(PersistentPrefStore::PREF_READ_ERROR_NO_FILE)).Times(1);
   message_loop_.RunUntilIdle();
   pref_store->RemoveObserver(&mock_observer);
 
   EXPECT_FALSE(pref_store->ReadOnly());
 }
 
-TEST_F(JsonPrefStoreTest, NeedsEmptyValue) {
-  FilePath pref_file = temp_dir_.path().AppendASCII("write.json");
-
-  ASSERT_TRUE(file_util::CopyFile(
-      data_dir_.AppendASCII("read.need_empty_value.json"),
-      pref_file));
+TEST_F(JsonPrefStoreTest, PreserveEmptyValues) {
+  FilePath pref_file = temp_dir_.path().AppendASCII("empty_values.json");
 
   // Test that the persistent value can be loaded.
-  ASSERT_TRUE(file_util::PathExists(pref_file));
   scoped_refptr<JsonPrefStore> pref_store =
-      new JsonPrefStore(
-          pref_file, message_loop_.message_loop_proxy());
-  ASSERT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, pref_store->ReadPrefs());
-  ASSERT_FALSE(pref_store->ReadOnly());
+      new JsonPrefStore(pref_file, message_loop_.message_loop_proxy());
 
-  // The JSON file looks like this:
-  // {
-  //   "list": [ 1 ],
-  //   "list_needs_empty_value": [ 2 ],
-  //   "dict": {
-  //     "dummy": true,
-  //   },
-  //   "dict_needs_empty_value": {
-  //     "dummy": true,
-  //   },
-  // }
-
-  // Set flag to preserve empty values for the following keys.
-  pref_store->MarkNeedsEmptyValue("list_needs_empty_value");
-  pref_store->MarkNeedsEmptyValue("dict_needs_empty_value");
-
-  // Set all keys to empty values.
+  // Set some keys with empty values.
   pref_store->SetValue("list", new base::ListValue);
-  pref_store->SetValue("list_needs_empty_value", new base::ListValue);
   pref_store->SetValue("dict", new base::DictionaryValue);
-  pref_store->SetValue("dict_needs_empty_value", new base::DictionaryValue);
 
   // Write to file.
   pref_store->CommitPendingWrite();
   MessageLoop::current()->RunUntilIdle();
 
-  // Compare to expected output.
-  FilePath golden_output_file =
-      data_dir_.AppendASCII("write.golden.need_empty_value.json");
-  ASSERT_TRUE(file_util::PathExists(golden_output_file));
-  EXPECT_TRUE(file_util::TextContentsEqual(golden_output_file, pref_file));
+  // Reload.
+  pref_store = new JsonPrefStore(pref_file, message_loop_.message_loop_proxy());
+  ASSERT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, pref_store->ReadPrefs());
+  ASSERT_FALSE(pref_store->ReadOnly());
+
+  // Check values.
+  const Value* result = NULL;
+  EXPECT_TRUE(pref_store->GetValue("list", &result));
+  ListValue().Equals(result);
+  EXPECT_TRUE(pref_store->GetValue("dict", &result));
+  DictionaryValue().Equals(result);
 }
 
 }  // namespace base