chrome/browser/signin/chrome_proximity_auth_client.h - Issue 1209193003: [Proximity Auth] Create one ProximityAuthClient per profile, rather than one global one.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/signin/chrome_proximity_auth_client.h

Issue 1209193003: [Proximity Auth] Create one ProximityAuthClient per profile, rather than one global one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up screenlock_private_api.cc a bit Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc ('K') | « chrome/browser/signin/OWNERS ('k') | chrome/browser/signin/chrome_proximity_auth_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SIGNIN_CHROME_PROXIMITY_AUTH_CLIENT_H_

	6 #define CHROME_BROWSER_SIGNIN_CHROME_PROXIMITY_AUTH_CLIENT_H_

	7

	8 #include "base/macros.h"

	9 #include "components/proximity_auth/proximity_auth_client.h"

	10

	11 class Profile;

	12

	13 // A Chrome-specific implementation of the ProximityAuthClient interface.

	14 // There is one \|ChromeProximityAuthClient\| per \|Profile\|.

	15 class ChromeProximityAuthClient : public proximity_auth::ProximityAuthClient {
	Mike Lerman 2015/06/29 13:41:28 This class really just provides one small function This class really just provides one small function now: Get the AuthenticatedUserName. Maybe this should just be an inner class / anonymous namespace class within the EasyUnlockService? The EasyUnlockService directly owns the reference anyways, and has access to the Profile. Ilya Sherman* 2015/06/29 18:03:38 I'm about to add more code to this class in a foll Show quoted text On 2015/06/29 13:41:28, Mike Lerman wrote: > This class really just provides one small function now: Get the > AuthenticatedUserName. Maybe this should just be an inner class / anonymous > namespace class within the EasyUnlockService? The EasyUnlockService directly > owns the reference anyways, and has access to the Profile*. I'm about to add more code to this class in a follow-up CL =) This is the embedder interface for the in-progress proximity_auth component, so it basically does everything that the component wants to do, but can't implement without reaching into //chrome
	16 public:

	17 explicit ChromeProximityAuthClient(Profile* profile);

	18 ~ChromeProximityAuthClient() override;

	19

	20 // proximity_auth::ProximityAuthClient:

	21 std::string GetAuthenticatedUsername() const override;

	22

	23 private:

	24 Profile* const profile_;

	25

	26 DISALLOW_COPY_AND_ASSIGN(ChromeProximityAuthClient);

	27 };

	28

	29 #endif // CHROME_BROWSER_SIGNIN_CHROME_PROXIMITY_AUTH_CLIENT_H_

OLD	NEW