Traverse into child LayoutViews during invalidateTreeIfNeeded

Source/core/frame/FrameView.h

 /*
    Copyright (C) 1997 Martin Jones (mjones@kde.org)
              (C) 1998 Waldo Bastian (bastian@kde.org)
              (C) 1998, 1999 Torben Weis (weis@kde.org)
              (C) 1999 Lars Knoll (knoll@kde.org)
              (C) 1999 Antti Koivisto (koivisto@kde.org)
    Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
@@ skipping 45 matching lines @@
 class HTMLFrameOwnerElement;
 class LayoutPart;
 class LocalFrame;
 class KURL;
 class Node;
 class LayoutBox;
 class LayoutEmbeddedObject;
 class LayoutObject;
 class LayoutScrollbarPart;
 class LayoutView;
+class PaintInvalidationState;
 class Page;
 class ScrollingCoordinator;
 class TracedValue;
 struct AnnotatedRegionValue;
 struct CompositedSelection;
 
 typedef unsigned long long DOMTimeStamp;
 
 class CORE_EXPORT FrameView final : public Widget, public ScrollableArea {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(FrameView);
@@ skipping 515 matching lines @@
     class InUpdateScrollbarsScope {
     public:
         explicit InUpdateScrollbarsScope(FrameView* view)
             : m_scope(view->m_inUpdateScrollbars, true)
         { }
     private:
         TemporaryChange<bool> m_scope;
     };
 
 private:
+    friend class LayoutPart; // For invalidateTreeIfNeeded.

[chrishtr, 2015/07/01 19:56:51]

We don't do that elsewhere, since friend classes can access all private methods,
which might lead to a worse outcome. I think it's better to leave it public and
put a note.

[Xianzhu, 2015/07/01 20:10:46]

Done.

+
     explicit FrameView(LocalFrame*);
 
     virtual void setScrollOffset(const IntPoint&, ScrollType) override;
     virtual void setScrollOffset(const DoublePoint&, ScrollType) override;
 
     void updateLayoutAndStyleForPaintingInternal();
     void invalidateTreeIfNeededRecursive();
     void scrollContentsIfNeededRecursive();
     void updateLayoutAndStyleIfNeededRecursive();
 
@@ skipping 12 matching lines @@
     void applyOverflowToViewport(LayoutObject*, ScrollbarMode& hMode, ScrollbarMode& vMode);
     void updateOverflowStatus(bool horizontalOverflow, bool verticalOverflow);
 
     void updateCounters();
     void forceLayoutParentViewIfNeeded();
     void performPreLayoutTasks();
     void performLayout(bool inSubtreeLayout);
     void scheduleOrPerformPostLayoutTasks();
     void performPostLayoutTasks();
 
-    void invalidateTreeIfNeeded(Vector<LayoutObject*>& pendingDelayedPaintInvalidations);
+    void invalidateTreeIfNeeded(PaintInvalidationState&);
 
     DocumentLifecycle& lifecycle() const;
 
     void contentRectangleForPaintInvalidation(const IntRect&);
     virtual void contentsResized() override;
     void scrollbarExistenceDidChange();
 
     // Override Widget methods to do point conversion via layoutObjects, in order to
     // take transforms into account.
     virtual IntRect convertToContainingView(const IntRect&) const override;
@@ skipping 223 matching lines @@
     static const unsigned visualPixelThreshold = 32 * 32;
     if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
         setIsVisuallyNonEmpty();
 }
 
 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFrameView());
 
 } // namespace blink
 
 #endif // FrameView_h