Traverse into child LayoutViews during invalidateTreeIfNeeded

Source/core/layout/LayoutPart.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Simon Hausmann <hausmann@kde.org>
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 313 matching lines @@
 
     if (widget->frameRect() == newFrame)
         return false;
 
     RefPtr<LayoutPart> protector(this);
     RefPtrWillBeRawPtr<Node> protectedNode(node());
     widget->setFrameRect(newFrame);
     return widget->frameRect().size() != newFrame.size();
 }
 
+PaintInvalidationReason LayoutPart::invalidatePaintIfNeeded(PaintInvalidationState& paintInvalidationState, const LayoutBoxModelObject& paintInvalidationContainer)
+{
+    if (widget() && widget()->isFrameView()) {
+        LayoutView* childLayoutView = toFrameView(widget())->layoutView();
+        if (!childLayoutView->isPaintInvalidationContainer()) {

[chrishtr, 2015/06/26 23:32:46]

Why can't you just pass down these parameters in the PaintInvalidationState
itself?

[Xianzhu, 2015/06/27 00:17:15]

We don't walk into the sub frames during a paint invalidation of a frame. The
FrameView recursively call LayoutView::invalidateTreeIfNeeded() for each frame
each with a new PaintInvalidationState. This CL let the new
PaintInvalidationStates get the states saved during the parent frame's
invalidateTreeIfNeeded().

Another way might be to let LayoutView::invalidateTreeIfNeeded() walk into sub
frames, and mark ancestor paint invalidation flags across frame boundaries. I'm
not sure how risky it is to do this.

[chrishtr, 2015/06/29 17:42:28]

This does seem a cleaner approach. To make it easier/safer, maybe just
FrameView::invalidateTreeIfNeeded() into LayoutView so you can call it from
here?

+            childLayoutView->setForceCheckForPaintInvalidationByParent(paintInvalidationState.forceCheckForPaintInvalidation());
+            childLayoutView->setPaintInvalidationCachedOffsetsEnabledByParent(paintInvalidationState.cachedOffsetsEnabled());
+        }
+    }
+
+    return LayoutReplaced::invalidatePaintIfNeeded(paintInvalidationState, paintInvalidationContainer);
 }
+
+}